AJAX BOB 4.7.1 Development/Discussion (don't post bugs here)

Stoney229 · Post by **Stoney229** » Mon Dec 03, 2007 12:58 am

Nobunaga wrote:Look at this:

... Where did I go wrong?

...

Use the "Map Centering Top" button on the BOB menu on the left to toggle the vertical alignment of the new army numbers overlay

Stoney229 · Post by **Stoney229** » Mon Dec 03, 2007 1:00 am

yeti_c wrote:VERSION : 2.19

FIXED :
Added Upgrade link to take you directly to the userscripts page

Added an id to the menu for LobsterCrush

C.

Thanks for the update!! I really admire how much work you've put into this and howskilled you are... I can say without a doubt it is the most impressive GM script I have ever even seen!

Aerial Attack · Post by **Aerial Attack** » Mon Dec 03, 2007 2:09 am

Did you make a change to the Bonus Cards code?

Now it says:

3 Bonus Cards3

whereas before, I think it just said

3

or maybe 3 Cards

This applies to 1, 2, 3, 4, or 5 cards held.

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 3:53 am

Aerial Attack wrote:Did you make a change to the Bonus Cards code?

Now it says:

3 Bonus Cards3

whereas before, I think it just said

3

or maybe 3 Cards

This applies to 1, 2, 3, 4, or 5 cards held.

Methinks you've got a weird refresh problem...

Can you reproduce? If so can you get me a screenshot?

C.

newline · Post by **newline** » Mon Dec 03, 2007 4:05 am

Aerial Attack wrote:Did you make a change to the Bonus Cards code?

Now it says:

3 Bonus Cards3

whereas before, I think it just said

3

or maybe 3 Cards

This applies to 1, 2, 3, 4, or 5 cards held.

the same is happing to me but only in a few games

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 5:01 am

Can't see that pic...

C.

rebelman · Post by **rebelman** » Mon Dec 03, 2007 6:25 am

yeti i know this was posted some time ago by others but 9 hours appearing as 0 hours on the countdown clock is giving me heart attacks as i usually click on "jump to next playable game" and when i seee i have just a few mins left i rush my move to get it finished in time when in reality i have buckets of time.

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 6:44 am

rebelman wrote:yeti i know this was posted some time ago by others but 9 hours appearing as 0 hours on the countdown clock is giving me heart attacks as i usually click on "jump to next playable game" and when i seee i have just a few mins left i rush my move to get it finished in time when in reality i have buckets of time.

The problem isn't mine actually - it's javascripts... it's parsing 09 as 0...

Pretty crap really...

I will try and work a workaround for it though...

C.

dpg · Post by **dpg** » Mon Dec 03, 2007 9:39 am

yeti_c wrote:
Aerial Attack wrote:Did you make a change to the Bonus Cards code?

Now it says:

3 Bonus Cards3
Methinks you've got a weird refresh problem...

Can you reproduce? If so can you get me a screenshot?

It is happening to me too. Here is a screenshot:

Cheers.

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 9:40 am

dpg wrote:
yeti_c wrote:
Aerial Attack wrote:Did you make a change to the Bonus Cards code?

Now it says:

3 Bonus Cards3
Methinks you've got a weird refresh problem...

Can you reproduce? If so can you get me a screenshot?
It is happening to me too. Here is a screenshot:

Cheers.

What game number is that?

C.

dpg · Post by **dpg** » Mon Dec 03, 2007 10:15 am

yeti_c wrote: What game number is that?

C.

1307729

(btw, I only noticed this today after I updated firefox to 2.0.0.11. That isn't to say it wasn't happening with an earlier firefox - just that I didn't notice it! :)

dpg · Post by **dpg** » Mon Dec 03, 2007 10:33 am

dpg wrote: (btw, I only noticed this today after I updated firefox to 2.0.0.11. That isn't to say it wasn't happening with an earlier firefox - just that I didn't notice it!

Hmmm... I just checked from another computer and it isn't happening there. Both are running firefox 2.0.0.11 and greasemonkey 0.7.20070607.0 - the only difference is the operating system - the problem occurs on the XP machine but not the windows 2000 one.

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 10:55 am

That game works fine for me on XP...

Can you reload the page then hold CTRL and press F5...

That text is the ALT text for the image by the way... so perhaps something went a bit wrong - and now it's in your cache...

Can you also check the cards display top right to see if it matches?

C.

CrabNebula · Post by **CrabNebula** » Mon Dec 03, 2007 11:03 am

The same problem started happening to me after I checked this thread and clicked Ctrl+F5 and it cleared my cache. So the problem's not with not clearing the cache!

dpg · Post by **dpg** » Mon Dec 03, 2007 11:08 am

Still getting the unwanted text included even after clearing the cache - funnily enough I am now seeing this on the windows 2000 machine too after I cleared the cache there.

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 11:26 am

Hmmm

This is odd...

yeti_c wrote: Can you also check the cards display top right to see if it matches?

C.

The1exile · Post by **The1exile** » Mon Dec 03, 2007 1:15 pm

If you mean the standard built in bonus card counter, that still shows as a proper image.

Might be stupid but maybe the image url was changed?

yeti_c · Post by **yeti_c** » Mon Dec 03, 2007 1:37 pm

The1exile wrote:If you mean the standard built in bonus card counter, that still shows as a proper image.

Might be stupid but maybe the image url was changed?

The weird thing is - all it does is copy that and write it out in the table!!!

C.

dpg · Post by **dpg** » Mon Dec 03, 2007 4:32 pm

yeti_c wrote:Can you also check the cards display top right to see if it matches?

Sorry, missed that request - top right display is normal with <image of a card>xN.

Cheers.

homes32 · Post by **homes32** » Mon Dec 03, 2007 5:20 pm

same prob here with the bonus card counter. the count is correct but have the extra text. also you should update the "script hompage" link on the userscipts.org page to point to this thread. thanks for all your hard work!

-homes

Ishiro · Post by **Ishiro** » Mon Dec 03, 2007 6:01 pm

The url for the image was changed.

Find code:

Code: Select all

            var cardStr = m_bonusCards ?  '<img width="18" height="16" title="' + playersArray[name]._cards + 
                                          ' Bonus Cards" alt="' + playersArray[name]._cards + ' Bonus Cards" class="icon3" src="images/cards.gif"/>' + playersArray[name]._cards + ' '
                                       :  '';

Replace with:

Code: Select all

            var cardStr = m_bonusCards ?  '<img width="18" height="16" title="' + playersArray[name]._cards + 
                                          ' Bonus Cards" alt="' + playersArray[name]._cards + ' Bonus Cards" class="icon3" src="static/cards.gif"/>' + playersArray[name]._cards + ' '
                                       :  '';

What happens is, the script cannot find the image, so it uses the Alt text. The Alt text is "N Bonus Cards". The image is always followed by the number of cards "N". So when the image cannot be found you get "N Bonus CardsN".

lackattack · Post by **lackattack** » Mon Dec 03, 2007 6:20 pm

So that's why I saw hits on the old cards.gif url after I moved the file

Herakilla · Post by **Herakilla** » Mon Dec 03, 2007 8:33 pm

lackattack wrote:So that's why I saw hits on the old cards.gif url after I moved the file

lol!

casper · Post by **casper** » Mon Dec 03, 2007 11:49 pm

thanks ishiro!!

no need to search for all that code though..

just find

Code: Select all

images/cards.gif

and replace with

Code: Select all

static/cards.gif

yeti_c · Post by **yeti_c** » Tue Dec 04, 2007 3:56 am

lackattack wrote:So that's why I saw hits on the old cards.gif url after I moved the file

GAH!!!

Curious as to why I didn't see it despite a CTRL F5... my cache must be holding onto a copy!!!

I'll upload a fixed version...

Cheers Ishiro.

C.