BoB version 1.2 problem explained

[Metaphore]

Link to a hopefully universal fix:

http://files.manfy.net/conquerclubbob.user.js

It's a good idea to uninstall whatever previous version you have first.

Apparently there are 2 version of XML floating around. Some maps use the <country> tag and others use the <territory> tag for the same element.

The original script works with <country> while Lobster's fix works with <territory>. What's needed is one that works with both.

The culprit seems to be this line in the original:

var entries = dom.getElementsByTagName('country');

and this in Lobster's:

var entries = dom.getElementsByTagName('territory');

What's needed is this for the original:

var entries = dom.getElementsByTagName('territory');
if (entries.length<1) {
entries = dom.getElementsByTagName('country');
}

And this for Lobster's:

var entries = dom.getElementsByTagName('country');
if (entries.length<1) {
entries = dom.getElementsByTagName('territory');
}

And it should work for all maps.

I'm hesitant to post yet another fix to prevent patch hell. Lobster, please add this to yours if you so chose.

OK, I hesitated... the link is at the top.

All credit to Lobster for finding the problem in the first place.

[Wild_Tiger]

Good Job

[Selin]

thanks for fixing Bob. that helped a lot.

saved search function does not work with "game labels" option. can you fix that too?

.

[mikeycgto]

can you elaborate more on the save search game label issue. Someone posted earlier about the problem and I didn't find anything wrong.

[Selin]

can you elaborate more on the save search game label issue. Someone posted earlier about the problem and I didn't find anything wrong.

I'm talking about stocksr' saved search script:

On the game finder menu you had the option to save your frequently used searchs, i.e. you could save a search "active, TOP 250", name it, and you automatically got all active games of tournament TOP 250 in 1 click by choosing that specific saved search.
Now it's partially working; the option to enter a partial match/ or a tournament name in saved searchs don't work. If you don't use partial match/or tournament fields, a saved search with all other options is working, e.g. a saved search with options "waiting, flat rate, standard...." does work.

I'm not sure, if I could explain it correctly. Is it clearer?

[Incandenza]

Thanks for the fix, bro.