One thing I do know is I don't want the game log to have 5 lines for a bonus when I can have one. That's why I like my code.
I think you're saying that you don't like how my XML includes Leader and 2nd in the name for the continent. You want it to be so the log will show whether you're getting the bonus for holding Leader or whether you're getting the bonus for holding 2nd. That's why you want to separate them. However, when you hold both, you've just overridden it to say you get the bonus for holding Leader. My problem with this is that someone will think, "Oh. I can just take out leader and he won't get the bonus." After they take out Leader, the player is still getting the same bonus but it will now say with 2nd. So, I think it's better to lump the continent and coding as 'Leader or 2nd' because it means less continents need to be coded and because it doesn't confuse people as to what the bonus actually is. For this same reason, I don't like naming Lieutenant and the Commissioner 'The Police'. We haven't put this on the legend and I think it will just confuse people. The map is already somewhat rules heavy and I don't think adding another thing to the legend will be helpful. The way it is now is somewhat bulky and cumbersome when I say, "Commissioner + Lieutenant + Six Patrol" but it's easy to understand.
One thing that leads to my XML being very long is I override every single continent. That comes before it. I don't think this needs to be done. I think we can just override the continent directly underneath it. This will cut down the lines drastically.
EG: currently my code looks like this
- Code: Select all
<continent>
<name>Commissioner + Lieutenant + Six Patrol</name>
<bonus>6</bonus>
<components>
<territory>Commissioner</territory>
<territory>Lieutenant</territory>
<continent>Six Patrol</continent>
</components>
<overrides>
<override>Commissioner + Lieutenant + One Patrol</override>
<override>Commissioner + Lieutenant + Two Patrol</override>
<override>Commissioner + Lieutenant + Three Patrol</override>
<override>Commissioner + Lieutenant + Four Patrol</override>
<override>Commissioner + Lieutenant + Five Patrol</override>
<override>Six Patrol</override>
</overrides>
</continent>
I believe all I need is this
- Code: Select all
<continent>
<name>Commissioner + Lieutenant + Six Patrol</name>
<bonus>6</bonus>
<components>
<territory>Commissioner</territory>
<territory>Lieutenant</territory>
<continent>Six Patrol</continent>
</components>
<overrides>
<override>Commissioner + Lieutenant + Five Patrol</override>
<override>Six Patrol</override>
</overrides>
</continent>
We need confirmation on this though.